[Mesa-dev] [PATCH 1/7] ac/nir: do not clamp shadow reference on GFX10

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Jul 18 13:51:27 UTC 2019


RadeonSI only uses Z32_FLOAT_CLAMP for upgraded depth textures
on GFX10 and RADV doesn't promotes Z16 or Z24.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/common/ac_nir_to_llvm.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 96bf89a8bf9..75ee534eb3e 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -3805,12 +3805,16 @@ static void visit_tex(struct ac_nir_context *ctx, nir_tex_instr *instr)
 
 	/* TC-compatible HTILE on radeonsi promotes Z16 and Z24 to Z32_FLOAT,
 	 * so the depth comparison value isn't clamped for Z16 and
-	 * Z24 anymore. Do it manually here.
+	 * Z24 anymore. Do it manually here for GFX8-9; GFX10 has an explicitly
+	 * clamped 32-bit float format.
 	 *
 	 * It's unnecessary if the original texture format was
 	 * Z32_FLOAT, but we don't know that here.
 	 */
-	if (args.compare && ctx->ac.chip_class >= GFX8 && ctx->abi->clamp_shadow_reference)
+	if (args.compare &&
+	    ctx->ac.chip_class >= GFX8 &&
+	    ctx->ac.chip_class <= GFX9 &&
+	    ctx->abi->clamp_shadow_reference)
 		args.compare = ac_build_clamp(&ctx->ac, ac_to_float(&ctx->ac, args.compare));
 
 	/* pack derivatives */
-- 
2.22.0



More information about the mesa-dev mailing list