[Mesa-dev] [PATCH] radv: fix dumping disassembly with RADV_DEBUG=shaders

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue Jul 23 08:09:29 UTC 2019


r-b

On Tue, Jul 23, 2019 at 9:51 AM Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
>
> Fixes: a20a9d0c5e7 ("radv: dont store disasm string unless keep_shader_info flag set")
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_shader.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
> index 3adaf52e152..736388c555c 100644
> --- a/src/amd/vulkan/radv_shader.c
> +++ b/src/amd/vulkan/radv_shader.c
> @@ -1013,7 +1013,8 @@ radv_shader_variant_create(struct radv_device *device,
>                         return NULL;
>                 }
>
> -               if (device->keep_shader_info) {
> +               if (device->keep_shader_info ||
> +                   (device->instance->debug_flags & RADV_DEBUG_DUMP_SHADERS)) {
>                         const char *disasm_data;
>                         size_t disasm_size;
>                         if (!ac_rtld_get_section_by_name(&rtld_binary, ".AMDGPU.disasm", &disasm_data, &disasm_size)) {
> --
> 2.22.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list