[Mesa-dev] [PATCH] radv/gfx10: fix VS input VGPRs with the legacy path

Samuel Pitoiset samuel.pitoiset at gmail.com
Tue Jul 23 11:46:20 UTC 2019


On 7/23/19 1:37 PM, Bas Nieuwenhuizen wrote:
> So does this work with tests that use multiple instances?
Apparently no.
>
> If so, r-b.
>
> On Tue, Jul 23, 2019 at 1:29 PM Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>   src/amd/vulkan/radv_nir_to_llvm.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c
>> index 336bae28614..9cea92e8a69 100644
>> --- a/src/amd/vulkan/radv_nir_to_llvm.c
>> +++ b/src/amd/vulkan/radv_nir_to_llvm.c
>> @@ -851,7 +851,8 @@ declare_vs_input_vgprs(struct radv_shader_context *ctx, struct arg_info *args)
>>                                  add_arg(args, ARG_VGPR, ctx->ac.i32, NULL); /* unused */
>>                          }
>>                  } else {
>> -                       if (ctx->ac.chip_class >= GFX10) {
>> +                       if (ctx->ac.chip_class >= GFX10 &&
>> +                           ctx->options->key.vs_common_out.as_ngg) {
>>                                  add_arg(args, ARG_VGPR, ctx->ac.i32, NULL); /* user vgpr */
>>                                  add_arg(args, ARG_VGPR, ctx->ac.i32, NULL); /* user vgpr */
>>                                  add_arg(args, ARG_VGPR, ctx->ac.i32, &ctx->abi.instance_id);
>> --
>> 2.22.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list