[Mesa-dev] [PATCH] nv50/ir: Add mul and mod constant optimizations
kherbst at redhat.com
Tue Jul 23 15:22:57 UTC 2019
yeah.. I am not quite sure myself about it. But skipping on the div
emulation seems like a good idea in general. But it's also not common
enough to actually care all that much about it.
On Tue, Jul 23, 2019 at 5:18 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Tue, Jul 23, 2019 at 11:15 AM Karol Herbst <kherbst at redhat.com> wrote:
> > On Tue, Jul 23, 2019 at 4:50 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> > >
> > > You handle 1/n but not 1%n? TBH, the 1/n code isn't 100% obvious to
> > > me... 1/n = |n|-1 > 0 ? .... i forget how SLCT works, but I can't
> > > think of a way to finish that expression in terms of |n|-1 and n. And
> > > what about n == 0. I'd just as soon drop that case.
> > >
> > is 1/0 actually defined in glsl? I thought that the result is
> > undefined and we can basically do whatever, no? At least intel seems
> > to return INT_MAX for 1/0
> If you guys really like it, just add more comments that cover my questions.
More information about the mesa-dev