[Mesa-dev] [PATCH] radv/gfx10: Disable DCC with scanout.

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Jul 25 14:40:39 UTC 2019


It's already disabled later in this function?

On 7/25/19 4:34 PM, Bas Nieuwenhuizen wrote:
> (a) radv does not set the DCC fields required yet.
> (b) radeonsi just broke their DCC metadata.
>
> Fixes: f8b6c5a1a63 "radeonsi: rewrite si_get_opaque_metadata, also for gfx10 support"
> ---
>   src/amd/vulkan/radv_image.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
> index 09413333cbb..4bcdb70214a 100644
> --- a/src/amd/vulkan/radv_image.c
> +++ b/src/amd/vulkan/radv_image.c
> @@ -161,6 +161,9 @@ radv_use_dcc_for_image(struct radv_device *device,
>   	if (image->shareable)
>   		return false;
>   
> +	if (radv_surface_has_scanout(device, create_info))
> +		return false;
> +
>   	/* TODO: Enable DCC for storage images. */
>   	if ((pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT) ||
>   	    (pCreateInfo->flags & VK_IMAGE_CREATE_EXTENDED_USAGE_BIT))


More information about the mesa-dev mailing list