[Mesa-dev] [PATCH] panfrost/midgard: Don't force constant on VLUT

[Tomeu Vizoso]

Cannot really review this myself, but:

Tested-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>

Thanks!

Tomeu

On Wed, 27 Feb 2019 at 04:36, Alyssa Rosenzweig <alyssa at rosenzweig.io> wrote:
>
> Previously, we forced a #0 inline constant tacked on for the lut
> instructions to mirror the blob's behaviour, which caused some
> suboptimal codegen due to our constant inlining implementation. Instead,
> just don't force a constant at all.
>
> Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
> ---
>  src/gallium/drivers/panfrost/midgard/midgard_compile.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
> index 65822d3b28f..f533572c05d 100644
> --- a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
> +++ b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
> @@ -1069,7 +1069,6 @@ emit_alu(compiler_context *ctx, nir_alu_instr *instr)
>                          .src0 = quirk_flipped_r24 ? SSA_UNUSED_1 : src0,
>                          .src1 = quirk_flipped_r24 ? src0         : src1,
>                          .dest = dest,
> -                        .inline_constant = (nr_inputs == 1) && !quirk_flipped_r24
>                  }
>          };
>
> --
> 2.20.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev