[Mesa-dev] [PATCH 1/2] panfrost/midgard: Promote smul to vmul

[Tomeu Vizoso]

Cannot really review this myself, but:

Tested-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>

Thanks!

On Wed, 27 Feb 2019 at 06:49, Alyssa Rosenzweig <alyssa at rosenzweig.io> wrote:
>
> smul comes first in the pipeline, before vmul. Until we have a full
> instruction scheduler, it's better to have vmul prioritized to maximize
> bundle size.
>
> Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
> ---
>  src/gallium/drivers/panfrost/midgard/midgard_compile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
> index f533572c05d..e37037ac737 100644
> --- a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
> +++ b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
> @@ -2162,7 +2162,7 @@ schedule_bundle(compiler_context *ctx, midgard_block *block, midgard_instruction
>                                                  if ((units & UNIT_SADD) && !(control & UNIT_SADD))
>                                                          unit = UNIT_SADD;
>                                                  else if (units & UNIT_SMUL)
> -                                                        unit = UNIT_SMUL;
> +                                                        unit = ((units & UNIT_VMUL) && !(control & UNIT_VMUL)) ? UNIT_VMUL : UNIT_SMUL;
>                                                  else if ((units & UNIT_VADD) && !(control & UNIT_VADD))
>                                                          unit = UNIT_VADD;
>                                                  else
> --
> 2.20.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev