[Mesa-dev] [PATCH 4/8] panfrost: Pass the fence down when flushing

Alyssa Rosenzweig alyssa at rosenzweig.io
Mon Mar 4 19:37:21 UTC 2019


> +	__u32 out_sync;

Why __u32 instead of u32 or uint32_t? I don't think we use the prefixed
types anywhere else.

> +	int (*init_context) (struct panfrost_context *ctx);
> +	void (*fence_reference) (struct pipe_screen *screen,
> +                         struct pipe_fence_handle **ptr,
> +                         struct pipe_fence_handle *fence);
> +	boolean (*fence_finish) (struct pipe_screen *screen,
> +                      struct pipe_context *ctx,
> +                      struct pipe_fence_handle *fence,
> +                      uint64_t timeout);

How should these be implemented on the non-DRM backend? If I just stub
out the corresponding routines, should everything work alright? (If
that's the case, then I'll do that; nothing you need to worry about. But
I'm not up to date on how fencing works on mainline.)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190304/f03ffdd1/attachment.sig>


More information about the mesa-dev mailing list