[Mesa-dev] [PATCH 6/8] panfrost: Free context BOs

[Tomeu Vizoso]

On 3/4/19 8:52 PM, Rob Herring wrote:
> On Mon, Mar 4, 2019 at 1:38 PM Alyssa Rosenzweig <alyssa at rosenzweig.io> wrote:
>>
>>>           unsigned transient_count = ctx->transient_pools[ctx->cmdstream_i].entry_index*ctx->transient_pools[0].entry_size + ctx->transient_pools[ctx->cmdstream_i].entry_offset;
>>> -     printf("Uploaded transient %d bytes\n", transient_count);
>>> +     //printf("Uploaded transient %d bytes\n", transient_count);

Sorry, this change slipped into this patch.

>> This will raised an unused variable warning for transient_count, better
>> comment both or neither.
> 
> Better yet, use a debug print so it can be enabled via an env var. Or
> if it's not that useful, just remove it.

Yeah, I couldn't tell because I don't really know what's the purpose of 
this printf.

>>
>> Other than that, Reviewed-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
>>
>> I wonder if this will fix some of the memory leaks on non-DRM as well.

I think it should, though it may not be that acute because of some lazy 
allocations that I think kbase does?

Cheers,

Tomeu