[Mesa-dev] [PATCH] radv: allocate enough space in cmdbuf when starting a subpass

[Samuel Pitoiset]

On 3/5/19 2:34 PM, Bas Nieuwenhuizen wrote:
> On Tue, Mar 5, 2019 at 10:42 AM Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> This fixes some CTS crashes with:
>> dEQP-VK.renderpass2.suballocation.attachment_write_mask.attachment_count_8.start_index_*
>>
>> Ideally, we should check cmd_buffer->cs->max_dw because there is
>> likely enough space (the internal clear draws allocate space), but
>> keep that way for consistency.
> Isn't this what check_space does?

I meant, at the end of that function.

> Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>   src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
>> index ad0b934ddfc..3e652018499 100644
>> --- a/src/amd/vulkan/radv_cmd_buffer.c
>> +++ b/src/amd/vulkan/radv_cmd_buffer.c
>> @@ -3446,7 +3446,7 @@ radv_cmd_buffer_begin_subpass(struct radv_cmd_buffer *cmd_buffer,
>>          struct radv_subpass *subpass = &state->pass->subpasses[subpass_id];
>>
>>          MAYBE_UNUSED unsigned cdw_max = radeon_check_space(cmd_buffer->device->ws,
>> -                                                          cmd_buffer->cs, 2048);
>> +                                                          cmd_buffer->cs, 4096);
>>
>>          radv_subpass_barrier(cmd_buffer, &subpass->start_barrier);
>>
>> --
>> 2.21.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev