[Mesa-dev] [PATCH] svga: remove SVGA_RELOC_READ flag in SVGA3D_BindGBSurface()

Thomas Hellstrom thellstrom at vmware.com
Fri Mar 8 06:42:32 UTC 2019


On Thu, 2019-03-07 at 19:45 -0700, Brian Paul wrote:
> This fixes a rendering issue where UBO updates aren't always picked
> up by drawing calls.  This issue effected the Webots robotics
> simulator.  VMware bug 2175527.
> 
> Testing Done: Webots replay, piglit, misc Linux games
> ---
>  src/gallium/drivers/svga/svga_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/svga/svga_cmd.c
> b/src/gallium/drivers/svga/svga_cmd.c
> index 5557d20..6577c83 100644
> --- a/src/gallium/drivers/svga/svga_cmd.c
> +++ b/src/gallium/drivers/svga/svga_cmd.c
> @@ -1693,7 +1693,7 @@ SVGA3D_BindGBSurface(struct svga_winsys_context
> *swc,
>        return PIPE_ERROR_OUT_OF_MEMORY;
>  
>     swc->surface_relocation(swc, &cmd->sid, &cmd->mobid, surface,
> -                           SVGA_RELOC_READ | SVGA_RELOC_INTERNAL);
> +                           SVGA_RELOC_READ);
>  
>     swc->commit(swc);
>  

Reviewed-by:
Thomas Hellström <thellstrom at vmware.com>



More information about the mesa-dev mailing list