[Mesa-dev] [PATCH 33/34] nv50/ir/nir: handle user clip planes for each emitted vertex

[Ilia Mirkin]

On Mon, Mar 11, 2019 at 8:18 PM Karol Herbst <kherbst at redhat.com> wrote:
>
> On Tue, Mar 12, 2019 at 1:09 AM Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> >
> > On Mon, Mar 11, 2019 at 8:05 PM Karol Herbst <kherbst at redhat.com> wrote:
> > >
> > > v9: convert to C++ style comments
> > > Signed-off-by: Karol Herbst <kherbst at redhat.com>
> > > ---
> > >  src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
> > > index 627848a457f..fdc6eaf759a 100644
> > > --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
> > > +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
> > > @@ -1561,7 +1561,7 @@ Converter::visit(nir_function *function)
> > >     bb->cfg.attach(&exit->cfg, Graph::Edge::TREE);
> > >     setPosition(exit, true);
> > >
> > > -   if (info->io.genUserClip > 0)
> > > +   if (prog->getType() == Program::TYPE_VERTEX && info->io.genUserClip > 0)
> >
> > What about TES? Did you mean && !TYPE_GEOMETRY perhaps?
> >
>
> yeah, that's missing. Thanks for pointing it out! Apparently we have
> no piglit test testing that.

Looks like we have them for geom shaders
(tests/spec/glsl-1.50/execution/compatibility/clipping) but not for
tess (the other compat tests are in
tests/spec/arb_tessellation_shader/execution/compatibility). Shouldn't
be difficult to add _something_, although extensive ones will be ...
confusing as always.

  -ilia