[Mesa-dev] [PATCH 2/2] nir: Remove unused variable unroll_loc
Timothy Arceri
tarceri at itsqueeze.com
Tue Mar 12 03:15:44 UTC 2019
On 12/3/19 2:09 pm, Alyssa Rosenzweig wrote:
>> A better fix might be to delete the Mesa src tree, that should fix up any
>> warnings :P
>
> Huh, so it does!
>
> No regressions on dEQP, possibly since all the tests were failing to
> begin with on Panfrost.
>
>> I can only assume this was sent out by mistake?
>
> This was sent out by "I don't know what I'm doing but there was a
> warning so I thought I'd nudge someone who knows".
:)
>
> I guess really the RHS should still be evaluated and just not stored
> anywhere?
>
The value is evaluated but only in debug builds. The correct fix is to
use MAYBE_UNUSED see [1]
[1] https://patchwork.freedesktop.org/patch/291616/
More information about the mesa-dev
mailing list