[Mesa-dev] [PATCH 9/9] mesa: Add assert to _mesa_primitive_restart_index.

Mathias.Froehlich at gmx.net Mathias.Froehlich at gmx.net
Thu Mar 14 12:33:47 UTC 2019


From: Mathias Fröhlich <mathias.froehlich at web.de>

Hi Brian,

You mean an assert like this?
This patch also made it together with the rest of the series through intels CI.

best

Mathias





Make sure the inde_size parameter is meant to be in bytes.

Signed-off-by: Mathias Fröhlich <Mathias.Froehlich at web.de>
---
 src/mesa/main/varray.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mesa/main/varray.h b/src/mesa/main/varray.h
index 0be57971bd7..2831720edfc 100644
--- a/src/mesa/main/varray.h
+++ b/src/mesa/main/varray.h
@@ -316,6 +316,9 @@ static inline unsigned
 _mesa_primitive_restart_index(const struct gl_context *ctx,
                               unsigned index_size)
 {
+   /* The index_size parameter is menat to be in bytes. */
+   assert(index_size == 1 || index_size == 2 || index_size == 4);
+
    /* From the OpenGL 4.3 core specification, page 302:
     * "If both PRIMITIVE_RESTART and PRIMITIVE_RESTART_FIXED_INDEX are
     *  enabled, the index value determined by PRIMITIVE_RESTART_FIXED_INDEX
-- 
2.20.1



More information about the mesa-dev mailing list