[Mesa-dev] [PATCH v5 00/11] anv: Implement VK_EXT_sample_locations

[Jason Ekstrand]

On Thu, Mar 14, 2019 at 7:08 PM Jason Ekstrand <jason at jlekstrand.net> wrote:

> Eleni,
>
> I made a comment on one of your patches and then I started getting lost in
> the churn.  It's easier to see what's going on if things are reordered and
> refactored a bit.  Unfortunately, what needed to be done was hard to
> explain and it was easier for me to just do the code motion and re-send the
> series.  I hope you understand.  This is one of those cases where it's
> easier for me to write code than English.
>
> One of the results of this refactor is that gen8 and gen7 changes happen at
> the same time.
>
> --Jason
>
>
>
> Eleni Maria Stea (9):
>   anv: Added the VK_EXT_sample_locations extension to the anv_extensions
>     list
>   anv: Set the values for the
>     VkPhysicalDeviceSampleLocationsPropertiesEXT
>   anv: Implemented the vkGetPhysicalDeviceMultisamplePropertiesEXT
>   anv/state: Take explicit sample locations in emit helpers
>   anv: Add support for non-dynamic sample locations
>

The above patches are all

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


>   anv: Added support for dynamic sample locations
>   anv: Optimized the emission of the default locations on Gen8+
>

I've got some concerns about these two.


>   anv: Removed unused header file
>   anv: Enabled the VK_EXT_sample_locations extension
>

These two are also

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


>
> Jason Ekstrand (2):
>   anv/pipeline: Refactor 3DSTATE_SAMPLE_MASK setup
>   anv: Break SAMPLE_PATTERN and MULTISAMPLE emit into helpers
>
>  src/intel/common/gen_sample_positions.h |  57 +++++++++
>  src/intel/vulkan/anv_cmd_buffer.c       |  17 +++
>  src/intel/vulkan/anv_device.c           |  45 ++++++++
>  src/intel/vulkan/anv_extensions.py      |   1 +
>  src/intel/vulkan/anv_genX.h             |   6 +
>  src/intel/vulkan/anv_private.h          |   7 ++
>  src/intel/vulkan/genX_blorp_exec.c      |   1 -
>  src/intel/vulkan/genX_cmd_buffer.c      |  12 ++
>  src/intel/vulkan/genX_pipeline.c        |  93 +++++++--------
>  src/intel/vulkan/genX_state.c           | 147 ++++++++++++++++++++----
>  10 files changed, 315 insertions(+), 71 deletions(-)
>
> --
> 2.20.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190314/31a5b3cf/attachment-0001.html>