[Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

Ilia Mirkin imirkin at alum.mit.edu
Fri Mar 15 12:30:31 UTC 2019


On Fri, Mar 15, 2019 at 8:21 AM Axel Davy <davyaxel0 at gmail.com> wrote:
> This is compatible with what I said. Nouveau determines the minimum
> number of samplers actually needed
> by the current shader, and internally unbinds those above (and rebinds
> if needed by new shader).

The things nouveau does today aren't necessarily the best thought out
things -- it's mostly this way because it's always been that way and
there's been no reason to change it. Also the (usage of the) API for
set_sampler_views changed underneath nouveau a while back, and nouveau
hasn't been adjusted for the new world, leading to occasional issues
(although most seem to have been fixed by adjusting set_samplers).

It's important to know what's active though, since that means fewer
buffers to "bind" to the draw (i.e. have to be in vram/etc), fewer
buffers to wait on, fewer texture slots to flush out if there's
coherency things going on.

Cheers,

  -ilia


More information about the mesa-dev mailing list