[Mesa-dev] [PATCH] nir: Constant values are per-column not per-component

Lionel Landwerlin lionel.g.landwerlin at intel.com
Wed Mar 20 12:21:34 UTC 2019


Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 19/03/2019 19:15, Jason Ekstrand wrote:
> ---
>   src/compiler/nir/nir.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
> index 67304af1d64..e4f012809e5 100644
> --- a/src/compiler/nir/nir.h
> +++ b/src/compiler/nir/nir.h
> @@ -59,6 +59,7 @@ extern "C" {
>   #define NIR_FALSE 0u
>   #define NIR_TRUE (~0u)
>   #define NIR_MAX_VEC_COMPONENTS 4
> +#define NIR_MAX_MATRIX_COLUMNS 4
>   typedef uint8_t nir_component_mask_t;
>   
>   /** Defines a cast function
> @@ -141,7 +142,7 @@ typedef struct nir_constant {
>       * by the type associated with the \c nir_variable.  Constants may be
>       * scalars, vectors, or matrices.
>       */
> -   nir_const_value values[NIR_MAX_VEC_COMPONENTS];
> +   nir_const_value values[NIR_MAX_MATRIX_COLUMNS];
>   
>      /* we could get this from the var->type but makes clone *much* easier to
>       * not have to care about the type.




More information about the mesa-dev mailing list