[Mesa-dev] [PATCH] softpipe: remove shadow_ref assert.

Dave Airlie airlied at gmail.com
Thu Mar 21 04:28:06 UTC 2019


From: Dave Airlie <airlied at redhat.com>

I don't think this really buys us anything and TG4 with cubemap arrays
falls over because sampler == 2, but otherwise works fine.

Fixes:
./bin/textureGather fs shadow r  CubeArray repeat

on softpipe with ARB_gpu_shader5 enabled.
---
 src/gallium/auxiliary/tgsi/tgsi_exec.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c
index 78159fc1d9f..be637d0be56 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_exec.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_exec.c
@@ -2306,7 +2306,6 @@ exec_tex(struct tgsi_exec_machine *mach,
          FETCH(&r[last], 0, TGSI_CHAN_W);
       }
       else {
-         assert(shadow_ref != 4);
          FETCH(&r[last], 1, TGSI_CHAN_X);
       }
 
-- 
2.20.1



More information about the mesa-dev mailing list