[Mesa-dev] radv: Implement VK_EXT_pipeline_creation_feedback. - sigfault - bisected

[Dieter Nützel]

Hello Bas,

sorry but your latest commit #5f5ac19f138
radv: Implement VK_EXT_pipeline_creation_feedback.

sigfault with every Vulkan apps for me.

Reverting it SOLVED it.

5f5ac19f138125b04d8ddedd6334b996f8925a4a is the first bad commit
commit 5f5ac19f138125b04d8ddedd6334b996f8925a4a
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Tue Mar 19 02:30:33 2019 +0100

     radv: Implement VK_EXT_pipeline_creation_feedback.

     Does what it says on the tin.

     The per stage time is only an approximation due to linking and
     the Vega merged stages.

     Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

:040000 040000 ea08bcac9b3630e10bf333c79227bcd0ed9a894b 
0924580849d9bc268e47be1248311ff3b5488c86 M src

I'm on the 'old' way compiling today:
./autogen.sh --prefix=/usr/local --with-dri-drivers="" 
--with-platforms=drm,x11 --with-gallium-drivers=r600,radeonsi,swrast 
--with-vulkan-drivers=radeon --enable-nine --enable-opencl 
--disable-opencl_icd --enable-libglvnd --enable-autotools

/home/dieter> vkcube
Speicherschutzverletzung (core dumped)
/home/dieter> vkcubepp
Speicherschutzverletzung (core dumped)

[46339.977530] vkcube[29027]: segfault at 7ff7951ae840 ip 
00007ff795146569 sp 00007ffda7d3d070 error 7 in 
libvulkan_radeon.so[7ff7950e4000+1cf000]
[46339.977536] Code: d2 f3 0f 10 25 5c 78 17 00 0f 55 d9 f3 0f 2a d0 f3 
0f c2 c2 06 0f 54 c4 f3 0f 58 c2 0f 56 c3 eb ab 53 48 89 fb e8 c7 39 fb 
ff <c7> 03 01 00 00 00 48 29 43 08 5b c3 66 66 2e 0f 1f 84 00 00 00 00

[46341.772768] vkcubepp[29040]: segfault at 7fde85d21840 ip 
00007fde85cb9569 sp 00007ffeb679dfc0 error 7 in 
libvulkan_radeon.so[7fde85c57000+1cf000]
[46341.772775] Code: d2 f3 0f 10 25 5c 78 17 00 0f 55 d9 f3 0f 2a d0 f3 
0f c2 c2 06 0f 54 c4 f3 0f 58 c2 0f 56 c3 eb ab 53 48 89 fb e8 c7 39 fb 
ff <c7> 03 01 00 00 00 48 29 43 08 5b c3 66 66 2e 0f 1f 84 00 00 00 00

/home/dieter> vulkaninfo | less
Speicherschutzverletzung (core dumped)

==========
VULKANINFO
==========

Vulkan Instance Version: 1.1.98



Instance Extensions:
====================
Instance Extensions     count = 16
         VK_EXT_acquire_xlib_display         : extension revision  1
         VK_EXT_debug_report                 : extension revision  9
         VK_EXT_debug_utils                  : extension revision  1
         VK_EXT_direct_mode_display          : extension revision  1
         VK_EXT_display_surface_counter      : extension revision  1
         VK_KHR_device_group_creation        : extension revision  1
         VK_KHR_display                      : extension revision 23
         VK_KHR_external_fence_capabilities  : extension revision  1
         VK_KHR_external_memory_capabilities : extension revision  1
         VK_KHR_external_semaphore_capabilities: extension revision  1
         VK_KHR_get_display_properties2      : extension revision  1
         VK_KHR_get_physical_device_properties2: extension revision  1
         VK_KHR_get_surface_capabilities2    : extension revision  1
         VK_KHR_surface                      : extension revision 25
         VK_KHR_xcb_surface                  : extension revision  6
         VK_KHR_xlib_surface                 : extension revision  6
Layers: count = 0
=======
Presentable Surfaces:
=====================
GPU id       : 0 (AMD RADV POLARIS10 (LLVM 9.0.0))
Surface type : VK_KHR_xcb_surface
Formats:                count = 2
         B8G8R8A8_SRGB
         B8G8R8A8_UNORM
Present Modes:          count = 3
         IMMEDIATE_KHR
         MAILBOX_KHR
         FIFO_KHR
VkSurfaceCapabilitiesKHR:
         minImageCount       = 2
         maxImageCount       = 0
         currentExtent:
                 width       = 256
                 height      = 256
         minImageExtent:
                 width       = 256
                 height      = 256
         maxImageExtent:
                 width       = 256
                 height      = 256
         maxImageArrayLayers = 1
         supportedTransform:
                 VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR
         currentTransform:
                 VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR
         supportedCompositeAlpha:
                 VK_COMPOSITE_ALPHA_OPAQUE_BIT_KHR
                 VK_COMPOSITE_ALPHA_INHERIT_BIT_KHR
         supportedUsageFlags:
                 VK_IMAGE_USAGE_TRANSFER_SRC_BIT
                 VK_IMAGE_USAGE_TRANSFER_DST_BIT
                 VK_IMAGE_USAGE_SAMPLED_BIT
                 VK_IMAGE_USAGE_STORAGE_BIT
                 VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
VkSurfaceCapabilities2EXT:
         supportedSurfaceCounters:
                 None

GPU id       : 0 (AMD RADV POLARIS10 (LLVM 9.0.0))
Surface type : VK_KHR_xlib_surface
Formats:                count = 2
         B8G8R8A8_SRGB
         B8G8R8A8_UNORM
Present Modes:          count = 3
         IMMEDIATE_KHR
         MAILBOX_KHR
         FIFO_KHR

Stops, here.

BTW
'vulkaninfo' sigfault for some days even without this commit for me.

[-]
         VK_KHR_shader_draw_parameters       : extension revision  1
         VK_KHR_storage_buffer_storage_class : extension revision  1
         VK_KHR_swapchain                    : extension revision 68
         VK_KHR_variable_pointers            : extension revision  1

Speicherschutzverletzung (core dumped)

[47457.342384] vulkaninfo[22580]: segfault at 0 ip 00007f19b4161107 sp 
00007ffc71e133a8 error 4 in libX11-xcb.so.1.0.0[7f19b4161000+1000]
[47457.342392] Code: 00 01 5d c3 0f 1f 80 00 00 00 00 c3 0f 1f 80 00 00 
00 00 e9 7b ff ff ff 66 2e 0f 1f 84 00 00 00 00 00 90 48 8b 87 30 0a 00 
00 <48> 8b 00 c3 0f 1f 44 00 00 48 8b 87 30 0a 00 00 89 70 40 c3 00 48

Apart from that our son could play...;-)

Need some sleep.

Dieter