[Mesa-dev] [PATCH] vl/dri3: remove the wait before getting back buffer

[Michel Dänzer]

On 2019-03-20 4:42 p.m., Liu, Leo wrote:
> The wait here is unnecessary since we got a pool of back buffers,
> and the wait for swap buffer will happen before the present pixmap,
> at the same time the previous back buffer will be put back to pool
> for reuse after the check for PresentIdleNotify event
> 
> Signed-off-by: Leo Liu <leo.liu at amd.com>
> 
>  [...]
> 
> @@ -626,13 +621,6 @@ vl_dri3_screen_texture_from_drawable(struct vl_screen *vscreen, void *drawable)
>     if (!dri3_set_drawable(scrn, (Drawable)drawable))
>        return NULL;
>  
> -   if (scrn->flushed) {
> -      while (scrn->special_event && scrn->recv_sbc < scrn->send_sbc)
> -         if (!dri3_wait_present_events(scrn))
> -            return NULL;
> -   }
> -   scrn->flushed = false;
> -
>     buffer = (scrn->is_pixmap) ?
>              dri3_get_front_buffer(scrn) :
>              dri3_get_back_buffer(scrn);
> 

Hmm. Is the wait here not necessary before getting a pixmap's front
buffer either though? Maybe wait only here for a pixmap, and only in
vl_dri3_flush_frontbuffer for a window?

Sorry I didn't realize this earlier.


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer