[Mesa-dev] [PATCH] mesa: Fix GL_NUM_DEVICE_UUIDS_EXT

Tapani Pälli tapani.palli at intel.com
Thu Mar 21 14:41:08 UTC 2019



On 3/21/19 4:03 PM, Józef Kucia wrote:
> On Thu, Mar 21, 2019 at 1:24 PM Tapani Pälli <tapani.palli at intel.com> wrote:
>> Yeah, checked that value matches of find_value_indexed;
>>
>> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
> 
> I don't have commits rights. Please push the patch for me.

sure

>> Does this affect 'ext_semaphore-api-errors' Piglit test that calls this
>> in any way?
> 
> No. Before the patch numDevices is 0 and 1 is invalid index anyway.
> 
> glGetUnsignedBytei_vEXT(GL_DEVICE_UUID_EXT, numDevices + 1, data);
> 

Right :/ I find it a bit bad that the return value is not checked at 
all, maybe should update that test, ideally it would have caught this one.

// Tapani


More information about the mesa-dev mailing list