[Mesa-dev] [PATCH 5/5] softpipe: add support for vertex streams

[Roland Scheidegger]

As long as there's no regressions in llvmpipe, looks great to me.

Am 29.03.19 um 06:48 schrieb Dave Airlie:
> This enables the ARB_gpu_shader5 vertex streams on softpipe.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/gallium/drivers/softpipe/sp_screen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c
> index 438557e146a..d2c31b8935d 100644
> --- a/src/gallium/drivers/softpipe/sp_screen.c
> +++ b/src/gallium/drivers/softpipe/sp_screen.c
> @@ -122,7 +122,7 @@ softpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_MAX_GEOMETRY_TOTAL_OUTPUT_COMPONENTS:
>        return 1024;
>     case PIPE_CAP_MAX_VERTEX_STREAMS:
> -      return 1;
> +      return PIPE_MAX_VERTEX_STREAMS;
I think technically you should make this dependent on
!sp_screen->use_llvm (unless you want to fix the llvm paths :-)).

For the series:
Reviewed-by: Roland Scheidegger <sroland at vmware.com>



>     case PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE:
>        return 2048;
>     case PIPE_CAP_PRIMITIVE_RESTART:
>