[Mesa-dev] Mesa (staging/19.0): radv: enable descriptor indexing capabilities

[Samuel Pitoiset]

On 5/2/19 2:27 AM, Bas Nieuwenhuizen wrote:
> Well, kinda a fix.  Jason noticed that there were parts of the ext I
> disabled but apparently implementations are required to enable them
> (see 028ce527395642b68612d10c6030be5d4706a65e).
>
> Though, I think this was backported under the assumption that
> 028ce527395642b68612d10c6030be5d4706a65e also was, and it looks like I
> did not CC that to 19.0, partially because of a lot of dependencies.
> Might make more sense to disable the ext on the 19.0 branch.
Yes, that seems better to disable it. Can you send a patch?
>
>
> On Wed, May 1, 2019 at 9:56 PM Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> wait what? Are we backporting a new feature into a stable branch? Do we
>> really need that?
>>
>> On 5/1/19 6:35 PM, GitLab Mirror wrote:
>>> Module: Mesa
>>> Branch: staging/19.0
>>> Commit: a1cdab7bd4ecad7c1c518fb8430613a7559d4f9d
>>> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a1cdab7bd4ecad7c1c518fb8430613a7559d4f9d
>>>
>>> Author: Juan A. Suarez Romero <jasuarez at igalia.com>
>>> Date:   Mon Apr 29 17:05:13 2019 +0200
>>>
>>> radv: enable descriptor indexing capabilities
>>>
>>> This enables the remaining capabilities in SPV_EXT_descriptor_indexing.
>>>
>>> Fixes: 0e10790558b "radv: Enable VK_EXT_descriptor_indexing."
>>>
>>> Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
>>> Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>>> (cherry picked from commit 06c9d7f9f94d9ab44a2b6148d9b5ec3f76c8d3db)
>>>
>>> ---
>>>
>>>    src/amd/vulkan/radv_shader.c | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
>>> index 2b45576bd41..7dd2fa2105c 100644
>>> --- a/src/amd/vulkan/radv_shader.c
>>> +++ b/src/amd/vulkan/radv_shader.c
>>> @@ -222,6 +222,8 @@ radv_shader_compile_to_nir(struct radv_device *device,
>>>                        .lower_ubo_ssbo_access_to_offsets = true,
>>>                        .caps = {
>>>                                .descriptor_array_dynamic_indexing = true,
>>> +                             .descriptor_array_non_uniform_indexing = true,
>>> +                             .descriptor_indexing = true,
>>>                                .device_group = true,
>>>                                .draw_parameters = true,
>>>                                .float64 = true,
>>>
>>> _______________________________________________
>>> mesa-commit mailing list
>>> mesa-commit at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-commit
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev