[Mesa-dev] [PATCH 00/10] Get rid of _NEW_ARRAY finally.

Mathias.Froehlich at gmx.net Mathias.Froehlich at gmx.net
Thu May 2 09:27:10 UTC 2019


From: Mathias Fröhlich <Mathias.Froehlich at gmx.net>

Hi,

This is the second part of the _NEW_ARRAY mesa state bit removal.
The code basically unifies the _mesa_array_element implementation
by using a cheap to compute vertex attribute setter selection together
with the bitmask iteration trick. Once this is in place we can remove
gl_context::aelt_context and wipe behind that removal.
Then there is a bug in dlist compilation that I found during the changes.
Fixing that enables even a bit further cleanup and better separation
between dlist compilation and the glArrayElement implementation.

The series went through intels CI system and did not flag any unexpected
failures.

Please review

thanks and best

Mathias


Mathias Fröhlich (10):
  mesa: Factor out index function that will have multiple use.
  mesa: Use glVertexAttrib*NV functions for fixed function attribs.
  mesa: Implement _mesa_array_element by walking enabled arrays.
  mesa: Rip out now unused gl_context::aelt_context.
  mesa: Remove the now unused _NEW_ARRAY state change flag.
  mesa: Constify static const array in api_arrayelt.c
  mesa: Remove the _glapi_table argument from _mesa_array_element.
  mesa: Set CurrentSavePrimitive in vbo_save_NotifyBegin.
  mesa: Correct the is_vertex_position decision for dlists.
  mesa: Leave aliasing of vertex and generic0 attribute to the dlist
    code.

 src/mesa/drivers/dri/i965/brw_state_upload.c |   1 -
 src/mesa/drivers/dri/r200/r200_context.c     |   1 -
 src/mesa/drivers/dri/radeon/radeon_context.c |   1 -
 src/mesa/main/api_arrayelt.c                 | 391 +++----------------
 src/mesa/main/api_arrayelt.h                 |   7 +-
 src/mesa/main/arrayobj.c                     |   1 -
 src/mesa/main/attrib.c                       |   1 -
 src/mesa/main/debug.c                        |   3 +-
 src/mesa/main/mtypes.h                       |   3 +-
 src/mesa/main/varray.c                       |  17 -
 src/mesa/vbo/vbo_attrib_tmp.h                |  14 -
 src/mesa/vbo/vbo_context.c                   |  15 -
 src/mesa/vbo/vbo_exec.c                      |  11 -
 src/mesa/vbo/vbo_exec_api.c                  |  14 +
 src/mesa/vbo/vbo_save_api.c                  |  33 +-
 15 files changed, 104 insertions(+), 409 deletions(-)

--
2.20.1



More information about the mesa-dev mailing list