[Mesa-dev] [Mesa-stable] [PATCH 2/5] intel/fs: Lower integer multiply correctly when destination stride equals 4.

Dylan Baker dylan at pnwbakers.com
Thu May 2 18:05:07 UTC 2019


Quoting Francisco Jerez (2019-04-29 16:04:19)
> Francisco Jerez <currojerez at riseup.net> writes:
> 
> > Because the "low" temporary needs to be accessed with word type and
> > twice the original stride, attempting to preserve the alignment of the
> > original destination can potentially lead to instructions with illegal
> > destination stride greater than four.  Because the CHV/BXT alignment
> > restrictions are now being enforced by the regioning lowering pass run
> > after lower_integer_multiplication(), there is no real need to
> > preserve the original strides anymore.
> >
> > Note that this bug can be reproduced on stable branches, but
> > back-porting would be non-trivial, because the fix relies on the
> > regioning lowering pass recently introduced.
> 
> This and PATCH 3 of this series should have landed with a:
> 
> Cc: 19.0 <mesa-stable at lists.freedesktop.org>
>     
> The paragraph above recommending against their inclusion in stable
> branches was referring to the *then* stable branches when the patch was
> written, a couple of weeks before the 19.0 branch point.  Unfortunately
> the series landed after the branchpoint and patches 2 and 3 missed the
> 19.0 branch they were intended for.  Any chance we could get these into
> the next 19.0 stable release?
> 
> Thanks to Tapani for realizing the problem!
> 

I've pulled these into the staging/19.0 branch, they'll be in the release next
week.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190502/615443b5/attachment.sig>


More information about the mesa-dev mailing list