[Mesa-dev] [PATCH] panfrost: Refactor blend descriptors

[Alyssa Rosenzweig]

> The blend shader enable bit is already described in the comments in
> the header; the blend shader is enabled when unk2 == 0.

I'm pretty sure that comment was from you, but thank you ;)

> (the blend shader has
> to be allocated within the same 2^24 byte range as the main shader for
> it to work properly anyways, even on Midgard, which is probably not
> implemented properly on mainline).

Indeed. Mainline Midgard blend shaders work (well, stubbed out so they
just do passthrough without any real blending, but the hardware is
correct). That said, we cap shader memory at 16MB upfront, which
"resolves" this problem.

> Maybe it would be better if these functions got passed the
> mali_shader_descriptor itself?

Possibly. I don't have access to any Bifrost machines right now, so I
can't test that.