[Mesa-dev] [PATCH] Revert "glx: Fix synthetic error generation in __glXSendError"

[Adam Jackson]

On Tue, 2019-05-07 at 20:17 +1000, Timothy Arceri wrote:

> I don't know enough about this code to take responsibility for such 
> changes. I was just trying to revert to the status quo until this could 
> be investigated again.
> 
> My suggestion is we roll back the recent change. Then someone needs to 
> create piglit test for both scenarios before trying to move forward again.
> 
> If you want to try something different then go for it :)

Don't feel bad about not understanding this code. Honestly what libGL
is doing here - fabricating an X11 protocol error out of thin air - is
completely unique to libGL among the X client libraries, and it's not
surprising that attempting to do causes issues.

I'm fine with any amount of revert here. I can't promise I'll have the
time to investigate this in any detail promptly though.

- ajax