[Mesa-dev] [PATCH 1/2] nir: Add is_divergent_vector search helper

Alyssa Rosenzweig alyssa at rosenzweig.io
Tue May 7 21:45:49 UTC 2019


> IMO better names might be is_scalar_swizzle or something.

Ah, yes, that would be a better name! is_not_scalar_swizzle in this case
(logic is flipped).

> Can num_components be 1? If so, then this will return false, whereas
> you probably wanted it to return true.

I think that's the correct behaviour...? It should return true if
multiple distinct channels are accessed. For nr_components=1, that's
false by definition.


More information about the mesa-dev mailing list