[Mesa-dev] [PATCH 09/11] panfrost: Fix two uninitialized accesses in compiler

Emil Velikov emil.l.velikov at gmail.com
Thu May 9 14:45:53 UTC 2019


On Thu, 9 May 2019 at 07:35, Tomeu Vizoso <tomeu.vizoso at collabora.com> wrote:
>
> Valgrind was complaining of those.
>
> NIR_PASS only sets progress to TRUE if there was progress.
>
> nir_const_load_to_arr() only sets as many constants as components has
> the instruction.
>
> This was causing some dEQP tests to flip-flop, such as:
>
> dEQP-GLES2.functional.fragment_ops.blend.equation_src_func_dst_func.add_src_color_constant_color
>
Please add a Fixes tag or a cc: mesa-stable@ one at least. This way
we'll pick this fix for stable.

-Emil


More information about the mesa-dev mailing list