[Mesa-dev] [PATCH 08/11] panfrost: ci: Skip running some tests

[Tomeu Vizoso]

On Thu, 9 May 2019 at 17:16, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>
> On Thu, 9 May 2019 at 07:35, Tomeu Vizoso <tomeu.vizoso at collabora.com> wrote:
> >
> > These tests add too much time to the total run time, and some of them
> > even hang the DUTs, even if I haven't been able to reproduce it locally.
> >
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> > ---
> >  src/gallium/drivers/panfrost/ci/deqp-runner.sh | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> > index 68d9bc1fc878..8d30eae28b04 100644
> > --- a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> > +++ b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> > @@ -27,9 +27,11 @@ sleep 1  # Give some time for Weston to start up
> >
> >  # Disable for now tests that are very slow, either by just using lots of CPU or by crashing
> >  sed -i '/dEQP-GLES2.performance/d' /tmp/case-list.txt
> > +sed -i '/dEQP-GLES2.stress/d' /tmp/case-list.txt
> IMHO not running stress/performance tests on each job makes sense. A
> longer interval - say once a week/month - would be reasonable.

Yep!

> >  sed -i '/dEQP-GLES2.functional.texture.filtering.2d.linear_mipmap_linear_/d' /tmp/case-list.txt
> >  sed -i '/dEQP-GLES2.functional.texture.filtering.cube.linear_mipmap_linear_/d' /tmp/case-list.txt
> >  sed -i '/dEQP-GLES2.functional.texture.filtering.cube.linear_mipmap_nearest_/d' /tmp/case-list.txt
> > +sed -i '/dEQP-GLES2.functional.fbo.render.depth./d' /tmp/case-list.txt
> >
> Pretty sure you or Alyssa will get to fixing these.
>
> Wondering if one cannot use a trivial visual reminder about these.
> Say printing some FIXME + tests in the logs. Or using an amber
> indication on successful pipeline - a green one when the list (modulo
> perf & stress tests) is empty?
> Perhaps even something better?

The logs are huge and IMO the best place to hide something you don't
want to ever stumble upon again :)

Was thinking that for now having them in the scripts is close to best,
probably along with an issue in Gitlab. This is still early stages, as
Panfrost matures we'll be able to do more interesting stuff.

Thanks!

Tomeu