[Mesa-dev] [PATCH] nv50/ir/nir: prefer to shift 1ull instead of 1ll

Pierre Moreau dev at pmoreau.org
Sun May 12 19:06:15 UTC 2019


Reviewed-by: Pierre Moreau <dev at pmoreau.org>

On 2019-05-12 — 15:51, Karol Herbst wrote:
> Signed-off-by: Karol Herbst <kherbst at redhat.com>
> Suggested-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
> index a9a24267245..7e59b83e8fc 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
> @@ -1334,7 +1334,7 @@ bool Converter::assignSlots() {
>           else
>              info->out[vary].mask |= ((1 << comp) - 1) << frac;
>  
> -         if (nir->info.outputs_read & 1ll << slot)
> +         if (nir->info.outputs_read & 1ull << slot)
>              info->out[vary].oread = 1;
>        }
>        info->numOutputs = std::max<uint8_t>(info->numOutputs, vary);
> @@ -1342,7 +1342,7 @@ bool Converter::assignSlots() {
>  
>     info->numSysVals = 0;
>     for (uint8_t i = 0; i < 64; ++i) {
> -      if (!(nir->info.system_values_read & 1ll << i))
> +      if (!(nir->info.system_values_read & 1ull << i))
>           continue;
>  
>        system_val_to_tgsi_semantic(i, &name, &index);
> -- 
> 2.21.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190512/a72d9ef4/attachment.sig>


More information about the mesa-dev mailing list