[Mesa-dev] [PATCH] radv: remove sisched hack for talos

[Dieter Nützel]

Am 15.03.2019 23:47, schrieb Timothy Arceri:
> On 16/3/19 6:53 am, Dieter Nützel wrote:
>> Am 15.03.2019 15:20, schrieb Samuel Pitoiset:
>>> Results of my benchmarks are:
>>> 
>>> 3 runs at 1080p:
>>> 
>>> GFX8: -1%
>>> 
>>> GFX9: -1.12%
>>> 
>>> 3 runs at 4k:
>>> 
>>> GFX8: -2%
>>> 
>>> GFX9: -1.85%
>>> 
>>> I'm actually not sure if we want to remove it...
>> 
>> Yes, my hint is we should wait until Marek is back from vacation.
>> Running all the time with AMD_DEBUB (R600_DEBUG)=nir,sisched 'cause 
>> it's
>> worth it...
> 
> Can you point to specific games that are helped?

My most prominent example is UH (>6% speedup), but Marek had drirc patch 
for US ages ago, too. UV 'only' 1%.

UH, sisched
Benchmark results:
Time:   260.602
Frames: 23609
FPS:    90.5942
Min FPS:        8.95326
Max FPS:        194.812
Score:  2282.07

UH
Benchmark results:
Time:   260.586
Frames: 22143
FPS:    84.9738
Min FPS:        8.85195
Max FPS:        185.081
Score:  2140.49

UV, sisched
Benchmark results:
Time:   189.126
Frames: 16232
FPS:    85.8264
Min FPS:        26.4919
Max FPS:        124.166
Score:  3590.98

UV
Benchmark results:
Time:   189.126
Frames: 16028
FPS:    84.7478
Min FPS:        27.965
Max FPS:        125.107
Score:  3545.85

Several progs/apps run 'smoother' with 'sisched' and there are some 
reports on Phoronix that best performance is achieved with 'sisched', 
too,

Greetings,
Dieter

>> 
>> Dieter
>> 
>>> On 3/15/19 11:25 AM, Timothy Arceri wrote:
>>>> This was added in 8a7d4092d260 but no longer seems to have any
>>>> impact on performance.
>>>> ---
>>>>   src/amd/vulkan/radv_device.c | 10 +---------
>>>>   1 file changed, 1 insertion(+), 9 deletions(-)
>>>> 
>>>> diff --git a/src/amd/vulkan/radv_device.c 
>>>> b/src/amd/vulkan/radv_device.c
>>>> index 9570c15af02..56421dbc74b 100644
>>>> --- a/src/amd/vulkan/radv_device.c
>>>> +++ b/src/amd/vulkan/radv_device.c
>>>> @@ -499,15 +499,7 @@ radv_handle_per_app_options(struct 
>>>> radv_instance *instance,
>>>>       if (!name)
>>>>           return;
>>>>   -    if (!strcmp(name, "Talos - Linux - 32bit") ||
>>>> -        !strcmp(name, "Talos - Linux - 64bit")) {
>>>> -        if (!(instance->debug_flags & RADV_DEBUG_NO_SISCHED)) {
>>>> -            /* Force enable LLVM sisched for Talos because it looks
>>>> -             * safe and it gives few more FPS.
>>>> -             */
>>>> -            instance->perftest_flags |= RADV_PERFTEST_SISCHED;
>>>> -        }
>>>> -    } else if (!strcmp(name, "DOOM_VFR")) {
>>>> +    if (!strcmp(name, "DOOM_VFR")) {
>>>>           /* Work around a Doom VFR game bug */
>>>>           instance->debug_flags |= RADV_DEBUG_NO_DYNAMIC_BOUNDS;
>>>>       }
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev