[Mesa-dev] [PATCH v2 0/3] u_dynarray: minor API cleanups
Nicolai Hähnle
nhaehnle at gmail.com
Mon May 13 14:58:05 UTC 2019
Hi all,
after reflecting on the comments a bit more, here's a v2 of the series
in which resize and grow are no-ops on reallocation failure, but get
MUST_CHECK attributes so that the compiler warns if the return value
isn't used.
It seems like almost all callers are well-behaved, except for a few
call-sites in nouveau. I'll leave it up to nouveau folks to decide
how to handle it, since there's no real regression: reallocation failure
wasn't handled properly before, and it still isn't handled properly.
Please review!
Thanks,
Nicolai
--
src/gallium/drivers/freedreno/a2xx/fd2_gmem.c | 12 +++----
src/gallium/drivers/freedreno/a3xx/fd3_gmem.c | 4 +--
src/gallium/drivers/freedreno/a4xx/fd4_gmem.c | 2 +-
src/gallium/drivers/freedreno/a5xx/fd5_gmem.c | 2 +-
src/gallium/drivers/freedreno/a6xx/fd6_gmem.c | 4 +--
src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 2 +-
src/gallium/drivers/nouveau/nv50/nv50_state.c | 5 ++-
src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 5 ++-
src/intel/compiler/brw_nir_analyze_ubo_ranges.c | 2 +-
src/mesa/drivers/dri/i965/brw_bufmgr.c | 4 +--
src/util/u_dynarray.h | 64 ++++++++++++++++++++++++-------------
11 files changed, 62 insertions(+), 44 deletions(-)
More information about the mesa-dev
mailing list