[Mesa-dev] [Review Request (master branch)] draw: fix memory leak introduced 7720ce32a

[Dave Airlie]

On Fri, 17 May 2019 at 07:42, Neha Bhende <bhenden at vmware.com> wrote:
>
> We need to free memory allocation PrimitiveOffsets in draw_gs_destroy().
> This fixes memory leak found while running piglit on windows.

Reviewed-by: Dave Airlie <airlied at redhat.com>
>
> Fixes: 7720ce32a ("draw: add support to tgsi paths for geometry streams. (v2)")
>
> Tested with piglit
>
> Reviewed-by: Brian Paul <brianp at vmware.com>
> Reviewed-by: Charmaine Lee <charmainel at vmware.com>
> ---
>  src/gallium/auxiliary/draw/draw_gs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/draw/draw_gs.c b/src/gallium/auxiliary/draw/draw_gs.c
> index 6420cfbb261..c752163ee05 100644
> --- a/src/gallium/auxiliary/draw/draw_gs.c
> +++ b/src/gallium/auxiliary/draw/draw_gs.c
> @@ -753,8 +753,10 @@ void draw_gs_destroy( struct draw_context *draw )
>  {
>     int i;
>     if (draw->gs.tgsi.machine) {
> -      for (i = 0; i < TGSI_MAX_VERTEX_STREAMS; i++)
> +      for (i = 0; i < TGSI_MAX_VERTEX_STREAMS; i++) {
>           align_free(draw->gs.tgsi.machine->Primitives[i]);
> +         align_free(draw->gs.tgsi.machine->PrimitiveOffsets[i]);
> +      }
>        tgsi_exec_machine_destroy(draw->gs.tgsi.machine);
>     }
>  }
> --
> 2.17.1
>