[Mesa-dev] [PATCH 2/2] mesa: unreference current winsys buffers when unbinding winsys buffers
Charmaine Lee
charmainel at vmware.com
Mon May 20 16:32:44 UTC 2019
>From: Brian Paul <brianp at vmware.com>
>Sent: Monday, May 20, 2019 6:39 AM
>To: Charmaine Lee; mesa-dev at lists.freedesktop.org; Neha Bhende; marek.olsak at amd.com
>Subject: Re: [PATCH 2/2] mesa: unreference current winsys buffers when unbinding winsys buffers
>Both look OK to me. Do they need to be tagged with "Cc:
mesa-stable at lists.freedesktop.org" for the stable branches?
>Reviewed-by: Brian Paul <brianp at vmware.com>
Yes, I will add the tag. Thanks Brian for reviewing.
-Charmaine
>On 05/18/2019 07:46 PM, Charmaine Lee wrote:
>> This fixes surface leak when no winsys buffers are bound.
>> ---
>> src/mesa/main/context.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
>> index 34da16b..04ef4d5 100644
>> --- a/src/mesa/main/context.c
>> +++ b/src/mesa/main/context.c
>> @@ -1765,6 +1765,10 @@ _mesa_make_current( struct gl_context *newCtx,
>>
>> check_init_viewport(newCtx, drawBuffer->Width, drawBuffer->Height);
>> }
>> + else {
>> + _mesa_reference_framebuffer(&newCtx->WinSysDrawBuffer, NULL);
>> + _mesa_reference_framebuffer(&newCtx->WinSysReadBuffer, NULL);
>> + }
>>
>> if (newCtx->FirstTimeCurrent) {
>> handle_first_current(newCtx);
>>
More information about the mesa-dev
mailing list