[Mesa-dev] [PATCH] i965/tex: ignore the diff between GL_TEXTURE_2D and GL_TEXTURE_RECTANGLE

[Olivier Fourdan]

Hi all,

On Thu, Jul 19, 2018 at 12:08 PM andrey simiklit
<asimiklit.work at gmail.com> wrote:
> > Ugh... not so good.  According to Oliver on the bug, this just make the assert go away and doesn't actually fix anything.  Likely this is needed but not sufficient.
>
> So as far as I understand Oliver found the bad commit in xorg glamor:
> https://bugs.freedesktop.org/show_bug.cgi?id=107287
>
> So at the moment we should fix just this "assertion" issue for Intel because "rendering" issue came from xorg/glamor and there is no "rendering" issue in Intel part.
> Please correct me if I incorrect.

Reviving an old thread/patch here.

Andrey, I reckon your patch here is still much needed as it fixes the
assert() issue:

intel_mipmap_tree.c:1301: intel_miptree_match_image: Assertion
`image->TexObject->Target == mt->target' failed.

Which is still occurring even with current master.

My patch was to fix the rendering issue (landed a while ago before
18.1 iirc), but yours was never merged and is still needed, I can
reproduce the assert() at will with the reproducer from
https://bugs.freedesktop.org/show_bug.cgi?id=107117

Jason, can we reconsider Andrii's patch? It still applies cleanly
(https://patchwork.freedesktop.org/patch/237490/)

Cheers,
Olivier