[Mesa-dev] [PATCH 01/30] pan/midgard: Add missing parans in SWIZZLE definition

[Boris Brezillon]

On Sat, 28 Sep 2019 15:02:06 -0400
Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com> wrote:

> TODO: Move me to front of series.

Looks like you've already done that :).

> 
> Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>


> ---
>  src/panfrost/midgard/helpers.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/panfrost/midgard/helpers.h b/src/panfrost/midgard/helpers.h
> index ac58fd50327..343fad0fea8 100644
> --- a/src/panfrost/midgard/helpers.h
> +++ b/src/panfrost/midgard/helpers.h
> @@ -189,7 +189,7 @@ quadword_size(int tag)
>  
>  /* Swizzle support */
>  
> -#define SWIZZLE(A, B, C, D) ((D << 6) | (C << 4) | (B << 2) | (A << 0))
> +#define SWIZZLE(A, B, C, D) (((D) << 6) | ((C) << 4) | ((B) << 2) | ((A) << 0))
>  #define SWIZZLE_FROM_ARRAY(r) SWIZZLE(r[0], r[1], r[2], r[3])
>  #define COMPONENT_X 0x0
>  #define COMPONENT_Y 0x1