[Mesa-dev] [PATCH] egl/gbm: Fix config validation

Robin Murphy robin.murphy at arm.com
Tue Oct 1 13:01:09 UTC 2019

[ + some CCs that I probably should have figured out first time around... ]

On 23/09/2019 16:40, Adam Jackson wrote:
> On Sat, 2019-09-21 at 18:07 +0100, Robin Murphy wrote:
>> In converting to shift/size-based validation, we lost a condition from
>> the ARGB/XRGB equivalence check, which left it working one way round
>> but not the other, and broke applications like glmark2-es2-drm on some
>> platforms. Restore the equivalent check that *both* configs actually
>> have an alpha channel before considering a mismatch.
>> Fixes: 7b4ed2b513ef ("egl: Convert configs to use shifts and sizes instead of masks")
>> Signed-off-by: Robin Murphy <robin.murphy at arm.com>
> Makes sense to me.
> Reviewed-by: Adam Jackson <ajax at redhat.com>

Thanks - assuming nobody else disagrees, is there a maintainer who could 
pick this up, or would I need to go off and do Gitlab shenanigans myself?


More information about the mesa-dev mailing list