[Mesa-dev] [PATCH v2] broadcom/vc4: Expand width of dst surface

apinheiro apinheiro at igalia.com
Mon Sep 2 07:17:29 UTC 2019


On 28/8/19 3:16, Zhaowei Yuan wrote:
> Four bytes of src_surf will be compressed into a 32-bits data
> and stored into dst_surf, and dst_surf is read as z-order,so
> its width must be aligned to multiples of 8(4x2) before devided

Nitpick: typo, "devided" instead of "divided".


With that change:

Reviewed-by: Alejandro PiƱeiro <apinheiro at igalia.com>


Do you have permissions to push this change by yourself, or do you need 
me to push it?


> by 2.
>
> Signed-off-by: Zhaowei Yuan <zhaowei.yuan at samsung.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111266
> ---
>   src/gallium/drivers/vc4/vc4_blit.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/vc4/vc4_blit.c b/src/gallium/drivers/vc4/vc4_blit.c
> index d3cc515..d379bcc 100644
> --- a/src/gallium/drivers/vc4/vc4_blit.c
> +++ b/src/gallium/drivers/vc4/vc4_blit.c
> @@ -360,7 +360,7 @@ vc4_yuv_blit(struct pipe_context *pctx, const struct pipe_blit_info *info)
>                   util_blitter_unset_running_flag(vc4->blitter);
>                   return false;
>           }
> -        dst_surf->width /= 2;
> +        dst_surf->width = align(dst_surf->width, 8) / 2;
>           if (dst->cpp == 1)
>                   dst_surf->height /= 2;
>   


More information about the mesa-dev mailing list