[Mesa-dev] [PATCH v3 06/25] panfrost: Get rid of unused panfrost_context fields

Alyssa Rosenzweig alyssa at rosenzweig.io
Thu Sep 5 19:57:25 UTC 2019


Reviewed-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>

I wish static analysis and friends would identify these automatically.

On Thu, Sep 05, 2019 at 09:41:31PM +0200, Boris Brezillon wrote:
> Some fields in panfrost_context are unused (probably leftovers from
> previous refactor). Let's get rid of them.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
> ---
>  src/gallium/drivers/panfrost/pan_context.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/gallium/drivers/panfrost/pan_context.h b/src/gallium/drivers/panfrost/pan_context.h
> index 8f9cc44fedac..9723d56ac5f7 100644
> --- a/src/gallium/drivers/panfrost/pan_context.h
> +++ b/src/gallium/drivers/panfrost/pan_context.h
> @@ -129,8 +129,6 @@ struct panfrost_context {
>          struct panfrost_bo *scratchpad;
>          struct panfrost_bo *tiler_heap;
>          struct panfrost_bo *tiler_dummy;
> -        struct panfrost_memory cmdstream_persistent;
> -        struct panfrost_memory depth_stencil_buffer;
>  
>          bool active_queries;
>          uint64_t prims_generated;
> @@ -157,8 +155,6 @@ struct panfrost_context {
>           * it is disabled, just equal to plain vertex count */
>          unsigned padded_count;
>  
> -        union mali_attr attributes[PIPE_MAX_ATTRIBS];
> -
>          /* TODO: Multiple uniform buffers (index =/= 0), finer updates? */
>  
>          struct panfrost_constant_buffer constant_buffer[PIPE_SHADER_TYPES];
> -- 
> 2.21.0


More information about the mesa-dev mailing list