[Mesa-dev] [PATCH v3 24/25] panfrost: Support batch pipelining

Alyssa Rosenzweig alyssa at rosenzweig.io
Fri Sep 6 12:10:55 UTC 2019


> Now, if we go for the dep graph solution, that's probably a non issue,
> since deps can be added at any point as long as they are described
> before the flush happens.
>
> [snip]
>
> Thanks for the detailed explanation. I'll look into that. This being
> said, I was wondering if we shouldn't merge this patch (after I
> addressed your first comment maybe) before getting involved in a more
> advanced solution (which I agree is what we should aim for).

If it's alright, I would prefer to focus on patches 1-23; most of it
looks wonderful so the few comments I had should be easily addressed for
the v2.

Once all of that initial work is merged (and your revision queue and my
review queue are cleared), we can circle back to this change.

I would prefer to go straight to a dep graph approach; this patch is a
good intermediate step for testing the earlier patches in the series but
given the extra complexity added for the draw flushing (which you
mention is only needed with the non-graph solution), I don't know if we
should merge.

Thoughts?


More information about the mesa-dev mailing list