[Mesa-dev] [PATCH] st/nir: fix illegal designated initializer in st_glsl_to_nir.cpp

Neha Bhende bhenden at vmware.com
Wed Sep 11 07:26:07 UTC 2019


Looks good to me.
Reviewed-by: Neha Bhende <bhenden at vmware.com>

Regards,
Neha

________________________________________
From: Brian Paul <brianp at vmware.com>
Sent: Wednesday, September 11, 2019 11:23 AM
To: mesa-dev at lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee; aio.oliveira at intel.com
Subject: [PATCH] st/nir: fix illegal designated initializer in st_glsl_to_nir.cpp

IIRC, designated initializers are not legal C++.
Fixes the MSVC build.

Fixes: 83fd1e58 ("glsl/nir: Add and use a gl_nir_link() function")
---
 src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp
index 280a778..d6a0264 100644
--- a/src/mesa/state_tracker/st_glsl_to_nir.cpp
+++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp
@@ -688,7 +688,7 @@ st_link_nir(struct gl_context *ctx,
     */
    if (shader_program->data->spirv) {
       static const gl_nir_linker_options opts = {
-         .fill_parameters = true,
+         true /*fill_parameters */
       };
       if (!gl_nir_link(ctx, shader_program, &opts))
          return GL_FALSE;
--
1.8.5.6



More information about the mesa-dev mailing list