[Mesa-dev] [Bug 111737] nir_opt_algebraic.c takes too long to compile

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Sep 18 15:24:32 UTC 2019


https://bugs.freedesktop.org/show_bug.cgi?id=111737

            Bug ID: 111737
           Summary: nir_opt_algebraic.c takes too long to compile
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: not set
          Priority: not set
         Component: glsl-compiler
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: idr at freedesktop.org
        QA Contact: intel-3d-bugs at lists.freedesktop.org

One our 72-thread build machine, release builds of Mesa used to take 90
seconds.  They now take closer to 8 minutes.  All of the extra time is spent
compiling nir_opt_algebraic.c.  Debug builds do not seem to be affected.  I
bisected this to:

f097247dd831da9b6e48baebc8b91efec3afcd28 is the first bad commit
commit f097247dd831da9b6e48baebc8b91efec3afcd28
Author: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
Date:   Wed Dec 12 16:29:13 2018 +0100

    nir/algebraic: disable inexact optimizations depending on float controls
execution mode

    If FLOAT_CONTROLS_SIGNED_ZERO_INF_NAN_PRESERVE or
    FLOAT_CONTROLS_DENORM_FLUSH_TO_ZERO are enabled, do not apply the
    inexact optimizations so the VK_KHR_shader_float_controls execution
    mode is respected.

    v2:
    - Do not apply inexact optimizations if SHADER_DENORM_FLUSH_TO_ZERO is
      enabled (Andres).

    v3:
    - Updated to renamed shader info member (Andres).

    v4:
    - Directly access execution mode instead of dragging it by parameter
(Caio).

    Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
    Signed-off-by: Andres Gomez <agomez at igalia.com>
    Reviewed-by: Connor Abbott <cwabbott0 at gmail.com> [v1]

:040000 040000 33e076aacc5a6a4f10065cac2c8b06af0a5439a2
2b4a6e086b09648fc67a1f219777d51dc96f60f5 M      src

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190918/6a22a42b/attachment.html>


More information about the mesa-dev mailing list