[Mesa-dev] [PATCH 2/3] android: compiler/nir: build nir_divergence_analysis.c

[Daniel Schürmann]

I don't know enough about build systems to review the last one, but this 
is also

Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>

On 22.09.19 14:05, mesa-dev-request at lists.freedesktop.org wrote:
> Date: Sun, 22 Sep 2019 12:00:25 +0200
> From: Mauro Rossi<issor.oruam at gmail.com>
> To:mesa-dev at lists.freedesktop.org
> Cc:daniel at schuermann.dev,samuel.pitoiset at gmail.com,
> 	bas at basnieuwenhuizen.nl, Mauro Rossi<issor.oruam at gmail.com>
> Subject: [Mesa-dev] [PATCH 2/3] android: compiler/nir: build
> 	nir_divergence_analysis.c
> Message-ID:<20190922100026.20134-2-issor.oruam at gmail.com>
>
> Prerequisite to avoid following radv linking error happening with aco
>
> FAILED: out/target/product/x86_64/obj_x86/SHARED_LIBRARIES/vulkan.radv_intermediates/LINKED/vulkan.radv.so
> ...
> external/mesa/src/amd/compiler/aco_instruction_selection_setup.cpp:178:
> error: undefined reference to 'nir_divergence_analysis'
> clang.real: error: linker command failed with exit code 1 (use -v to see invocation)
>
> Fixes: df86c5f ("nir: add divergence analysis pass.")
> Signed-off-by: Mauro Rossi<issor.oruam at gmail.com>
> ---
>   src/compiler/Makefile.sources | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/compiler/Makefile.sources b/src/compiler/Makefile.sources
> index c4d2c2be7c..bc49e00525 100644
> --- a/src/compiler/Makefile.sources
> +++ b/src/compiler/Makefile.sources
> @@ -215,6 +215,7 @@ NIR_FILES = \
>   	nir/nir_control_flow_private.h \
>   	nir/nir_deref.c \
>   	nir/nir_deref.h \
> +	nir/nir_divergence_analysis.c \
>   	nir/nir_dominance.c \
>   	nir/nir_format_convert.h \
>   	nir/nir_from_ssa.c \
> -- 2.20.1