[Mesa-dev] [PATCH] egl/gbm: Fix config validation

Adam Jackson ajax at redhat.com
Mon Sep 23 15:40:54 UTC 2019


On Sat, 2019-09-21 at 18:07 +0100, Robin Murphy wrote:
> In converting to shift/size-based validation, we lost a condition from
> the ARGB/XRGB equivalence check, which left it working one way round
> but not the other, and broke applications like glmark2-es2-drm on some
> platforms. Restore the equivalent check that *both* configs actually
> have an alpha channel before considering a mismatch.
> 
> Fixes: 7b4ed2b513ef ("egl: Convert configs to use shifts and sizes instead of masks")
> Signed-off-by: Robin Murphy <robin.murphy at arm.com>

Makes sense to me.

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax



More information about the mesa-dev mailing list