[Mesa-dev] [Review Request (master branch)] svga: Use pipe_shader_state_from_tgsi to set shader state

[Brian Paul]

I'm going to update the docs regarding patches and gitlab.  It's kind of 
a mess now.

-Brian


On 02/11/2020 03:03 AM, Michel Dänzer wrote:
> 
> Hi Charmaine,
> 
> 
> it looks like you pushed this patch and another one directly to the main
> Mesa repository master branch.
> 
> Pushing directly to the main Mesa repository is no longer common
> practice, and indeed discouraged, as it circumvents the pre-merge GitLab
> CI pipeline and forfeits all other benefits of a merge request (MR).
> 
> The common practice is to create an MR (normally already for patch
> review) and assign it to Marge Bot for merging. Marge will rebase as
> needed and merge once the pre-merge CI pipeline has passed.
> 
> 
> Thanks,
> 
> 
> On 2020-01-29 5:14 p.m., Neha Bhende wrote:
>> Use pipe_shader_state_from_tgsi() to set shader state for transformed
>> shader so that we get all correct data for respective shader state.
>>
>> This fixes several regressed glretrace, piglit crashes found during merging
>> upsteam mesa
>>
>> Fixes: bf12bc2dd7a2 (draw: add nir info gathering and building support)
>>
>> Reviewed-by: Charmaine Lee <charmainel at vmware.com>
>> ---
>>   src/gallium/drivers/svga/svga_state_tgsi_transform.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/svga/svga_state_tgsi_transform.c b/src/gallium/drivers/svga/svga_state_tgsi_transform.c
>> index b567aab6bc8..9d701b73772 100644
>> --- a/src/gallium/drivers/svga/svga_state_tgsi_transform.c
>> +++ b/src/gallium/drivers/svga/svga_state_tgsi_transform.c
>> @@ -131,7 +131,7 @@ emulate_point_sprite(struct svga_context *svga,
>>            tgsi_dump(new_tokens, 0);
>>         }
>>   
>> -      templ.tokens = new_tokens;
>> +      pipe_shader_state_from_tgsi(&templ, new_tokens);
>>         templ.stream_output.num_outputs = 0;
>>   
>>         if (streamout) {
>>
> 
>