[Mesa-dev] [Review Request (master branch)] compiler: change datatype of 'spacing' in shader_info with uint_8

Neha Bhende bhenden at vmware.com
Wed Jan 29 16:16:35 UTC 2020


With msvc compiler, enum is signed int. It caused failures with
piglit test and glretrace gl4_arb_tessellation_shader_v1

Fixes 84a1a2578dab ('compiler: pack shader_info from 160 bytes to 96 bytes')

Fixes vmware bug 2480550

Reviewed-by: Brian Paul <brianp at vmware.com>
Reviewed-by: Charmaine Lee <charmainel at vmware.com>
---
 src/compiler/shader_info.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h
index d13e51a47a6..233ee84893a 100644
--- a/src/compiler/shader_info.h
+++ b/src/compiler/shader_info.h
@@ -312,7 +312,7 @@ typedef struct shader_info {
 
          /** The number of vertices in the TCS output patch. */
          uint8_t tcs_vertices_out;
-         enum gl_tess_spacing spacing:2;
+         uint8_t spacing:2; // enum gl_tess_spacing
 
          /** Is the vertex order counterclockwise? */
          bool ccw:1;
-- 
2.17.1



More information about the mesa-dev mailing list