[Mesa-dev] [PATCH v2 1/7] nv50/ir: add nv50_ir_prog_info_out

Emil Velikov emil.l.velikov at gmail.com
Wed Mar 4 17:36:41 UTC 2020

Hi Mark,

On Fri, 21 Feb 2020 at 12:20, Mark Menzynski <mmenzyns at redhat.com> wrote:

> -   ret = nv50_ir_generate_code(info);
> +   /* these fields might be overwritten by the compiler */
> +   info_out.bin.smemSize = prog->cp.smem_size;
> +   info_out.io.genUserClip = prog->vp.num_ucps;
> +
I suspect that these two should be not be the out "version" of the
variables, but more like in the final patch.
Especially since nv50_ir_generate_code indiscriminately overrides info_out.

While I haven't looked at the code too closely, if does seem like this
commit causes an intermittent regression... Or perhaps we're lucky and
things just work ;-)

Either way, huge thanks for the update. Doubt I'll have the chance to
do a proper review, despite that the performance numbers look great.

> +   ret = nv50_ir_generate_code(info, &info_out);
>     if (ret) {
>        NOUVEAU_ERR("shader translation failed: %i\n", ret);
>        goto out;
>     }


More information about the mesa-dev mailing list