[Mesa-dev] [radeonsi] Re: glthread: upload non-VBO vertices and indices for non-Indirect non-IBM draws - BISECTED

[Dieter Nützel]

Hello Marek,

this was time and nerve consuming (with all the LLVM 11 
revert/re-revert).
FreeCAD vbo rendering bugs.

Mesa-20.1-rc4 is fine (sure)

Mesa git with #2840bc3065b reverted (glthread_draw.c deleted), too.

/opt/mesa> git bisect bad
2840bc3065b9e991b2c5880a2ee02e2458a758c4 is the first bad commit
commit 2840bc3065b9e991b2c5880a2ee02e2458a758c4
Author: Marek Olšák <marek.olsak at amd.com>
Date:   Fri Mar 6 16:56:54 2020 -0500

     glthread: upload non-VBO vertices and indices for non-Indirect 
non-IBM draws

     This is basically the same thing u_vbuf does.

     Part-of: 
<https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4314>

  src/mapi/glapi/gen/ARB_base_instance.xml           |   9 +-
  .../glapi/gen/ARB_draw_elements_base_vertex.xml    |  12 +-
  src/mapi/glapi/gen/ARB_draw_instanced.xml          |   6 +-
  src/mapi/glapi/gen/gl_API.xml                      |  15 +-
  src/mesa/Makefile.sources                          |   1 +
  src/mesa/main/glthread.c                           |   7 +
  src/mesa/main/glthread.h                           |   1 +
  src/mesa/main/glthread_draw.c                      | 982 
+++++++++++++++++++++
  src/mesa/meson.build                               |   1 +
  9 files changed, 1006 insertions(+), 28 deletions(-)
  create mode 100644 src/mesa/main/glthread_draw.c

Next 'night' I'll make an entry at gitlab, if you don't outpace me...;-)

Dieter