[Mesa-dev] [PATCH v3 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

[Marek Olšák]

bptc-float-modes is fixed by:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6774

Marek

On Tue, Sep 22, 2020 at 4:33 AM Denis Pauk <pauk.denis at gmail.com> wrote:

> Hi Dave,
>
> Could you please check
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6809/diffs ?
>
> It contains possible fixes for bptc rgba unorm. Bug is related to
> incorrect reuse current bit_offet reuse between iterations.
>
> Decompress rgb_float has left without fixes for now.
>
> On Sat, May 23, 2020 at 12:47 PM Denis Pauk <pauk.denis at gmail.com> wrote:
>
>> Hi Dave,
>>
>> I had tested code before only with bptc-modes and bptc-float-modes from
>> piglit. It was free time project, so no real tests.
>>
>> Code had reused implementation from intel classic driver if i correctly
>> remember.
>>
>> Maybe something wrong with pixel type conversion. I will check.
>>
>> On Sun, May 10, 2020 at 10:26 AM Dave Airlie <airlied at gmail.com> wrote:
>>
>>> On Wed, 27 Jun 2018 at 06:36, Denis Pauk <pauk.denis at gmail.com> wrote:
>>> >
>>> > Reuse code shared with mesa/main/texcompress_bptc.
>>> >
>>> > v2: Use block decompress function
>>> > v3: Include static bptc code from texcompress_bptc_tmp.h
>>> >     Suggested-by: Marek Olšák <maraeo at gmail.com>
>>> >
>>> > Signed-off-by: Denis Pauk <pauk.denis at gmail.com>
>>> > CC: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>> > CC: Marek Olšák <maraeo at gmail.com>
>>> > CC: Gert Wollny <gw.fossdev at gmail.com>
>>> > ---
>>>
>>> Hi Denis,
>>>
>>> not sure you are still around or interested in this code, but I've
>>> recently run Vulkan CTS over it and it fails some bc7 tests.
>>>
>>> It also fails a piglit test that I'm not sure is related or not yet.
>>>
>>> It only seems to be a corner case failure, like 6 or 7 pixels in the
>>> CTS cases, but I'm wondering if you have any insight or memory of
>>> where it might diverge.
>>>
>>> Dave.
>>>
>>
>>
>> --
>> Best regards,
>>                   Denis.
>>
>
>
> --
> Best regards,
>                   Denis.
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20200922/ecb1e337/attachment.htm>